Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pattern demo repair suite #568

Merged
merged 7 commits into from
Nov 14, 2022
Merged

fix: pattern demo repair suite #568

merged 7 commits into from
Nov 14, 2022

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Nov 14, 2022 •
edited
Loading

Overview

  • Many major and minor fixes to demo.
  • Load a few new patterns.

Related

Changes

  • feat(css): allow making all hyperlinks irregular
  • fix(css): rely on core styles colors
  • fix(css): c-button font size to ignore --as-link
  • fix(css): let core-styles control c-button max-width (it got fixed)
  • feat(core-styles): load newly added or documented patterns
  • fix(taccsite_ui): build & load core-styles to fix broken paths in demo
  • fix(core-styles): load relevant fixes

Testing & UI

See TACC/Core-Styles#66.

@wesleyboar
feat(css): allow making all hyperlinks irregular
c4ba368
@wesleyboar
fix(css): rely on core styles colors
fe3c242 
- Frontera still overrides these with its brown colors.
- TUP CMS will be updated to use its blue colors.
@wesleyboar
fix(css): c-button font size to ignore --as-link
4d7febf 
A c-button--as-link must use font-size inherit (from core-styles) to be same size as surrounding text. But CMS overwrite was breaking that feature.
@wesleyboar
fix(css): c-button max-width now auto (from core)
41eb48b 
Let c-button max-width be controlled by core-styles again.

Core Styles has a fix in TACC/Core-Styles@369b5a1.
@wesleyboar wesleyboar changed the title fix(core-styles): pattern demo repair suite fix: pattern demo repair suite Nov 14, 2022
@wesleyboar wesleyboar mentioned this pull request Nov 14, 2022
Merged
@wesleyboar
fix(core-styles): load new﹡ patterns
fd3bb13 
﹡ newly documented or created
@wesleyboar
fix(ui): build & load core-styles to fix paths
dbb567a 
- Build core-styles from node_modules.
- Load the locally built core-styles.
- Do not use symlinks (they cause confusion and bugs).
@wesleyboar
fix(core-styles): load relevant fixes
72bb5a2
@wesleyboar wesleyboar merged commit 92ecf40 into main Nov 14, 2022
@wesleyboar wesleyboar deleted the fix/bugs-found-in-client-demo branch November 14, 2022 22:01
@wesleyboar wesleyboar mentioned this pull request Nov 14, 2022
Merged
@wesleyboar wesleyboar mentioned this pull request Aug 16, 2022
Merged
wesleyboar added a commit that referenced this pull request Nov 13, 2023
@wesleyboar
fix(django): implement djangocms-text-ckeditor#568 (#540)
cd2d6d9 
Implement the #568 fix from PR #590 until we update our ckeditor to v5.

This will save H.P. (main CMS admin/designer) so many tiny bits of time.
wesleyboar added a commit that referenced this pull request Nov 13, 2023
@wesleyboar
Bugfix/djangocms text ckeditor 568 from 590 (#541)
7fa5305 
* fix(django): implement djangocms-text-ckeditor#568

Implement the #568 fix from PR #590 until we update our ckeditor to v5.

This will save H.P. (main CMS admin/designer) so many tiny bits of time.

* fix(django): working remote url for remote css

Fixes: #540

* fix: delete unrelated file added during merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar